Answers to: Serenity theme of Cockpit got problem [Ivy 7.3.1]

Comment by Lukas Lieb on An Truong's question

Lukas Lieb — Fri, 11 Oct 2019 04:21:20 -0400

Hi An

We don't force customers to use our supported themes. We want to give customers the possibility to build their projects with e.g. serenity. You still have the possibility to generate or use our own theme. You are free to delete our delivered themes too, but with the consequence that our tools not work without them.

So if you have your own theme, include it in our app. The cockpit will not be affected by this and should not affect your app. If you don't want to have those files in your app then don't import them. But the cockpit import those files and use them.

Regards

Lukas

Comment by An Truong on Lukas Lieb's answer

An Truong — Thu, 10 Oct 2019 22:45:57 -0400

Hi Lukas,

Thanks for your answer. But I have the little different opinion.

I think the development tool like Ivy shouldn't force customer application to use its theme. We have our own UI/ UX and we dont want to be affected by the development tool. As I understand now, the Serenity theme included in Ivy is for the Cockpit page, I not yet see the benefits to have it in our application.

Serenity 1.01 is just our base, it became KLARA theme itself already. And we are developing it day by day so we accept the risk of Primefaces upgrading.

We are doing somethings like your suggestions already. But the problem is we don't want to have the files like: nanoscroller.js/css, ripple.js/css, layout.js and also 2 css files generated by Serenity theme: layout.css and theme.css, because they are unnecessary for us. That's why I asked if we can exclude the Ivy Serenity theme in our app and only use it in Cockpit

Thanks for your support. Bests

Answer by Lukas Lieb

Lukas Lieb — Thu, 10 Oct 2019 03:38:56 -0400

Hi An

First of all it's a very bad thing to change the code of a framework. With this action you will have problems every time you need to do an update. Ok, you want to stay on the version 1.0.1 but what if this version gets incompatible with Primefaces itself? But this only as side note.

I think it should be still possible to use your own serenity theme, even whit the version 1.0.1. But for this you need your own theme name. If you have your WEB-INF/lib folder first of all don't delete the normal serenity jars, you can put your own jars beside them. E.g:

May you need to repackage the Serenity java classes in the theme jar too. (http://repackage.org/)

To use your theme now import them in your template.xhtml file:

Kind regards

Lukas

Answer by An Truong

An Truong — Wed, 09 Oct 2019 22:46:52 -0400

Hi all,

[https://www.dropbox.com/s/q75ie4veaokjrdu/Frame%201.jpg?dl=0]2

As KLARA is developing our theme based on Serenity theme 1.01 we bought last year, we don't want to upgrade the theme anymore, we want to use our developing version.

Since Ivy started to include the new Serenity theme, we have one more layer to overwrite. Imo, Serenity just should be included in the project where it needed like the Cockpit. It shouldn't affect to customer project like KLARA. We can put our theme to our project, it still works normally but it is not best practice for us. Serenity is overwriting the styling of Primefaces by wrapping one more tag out of all css stylings like: body .ui-input-text{}. If KLARA wants to have our own stylings, we must have one more identifier wrapper. Moreover, the Serenity theme will load to the template on client side 3 more files which are:

layout.css - Serenity layout styling
theme.css - Primefaces overwriting styling
layout.js - Primefaces components overwriting scripts

We already optimised and minified the scripts and performance for template in our side. Now if the Serenity jar included, there are more files we couldn't touch unless overwriting. We would prefer to use the original Primefaces codes where we already developed a lot of customisation codes than overwriting one more level in Serenity.

So our question is: Is there anyway that we can ignore the Serenity theme included in Ivy in our project?

Thank you very much for your support! Regards, An.

Comment by Reguel Wermelinger on Lukas Lieb's answer

Reguel Wermelinger — Fri, 04 Oct 2019 04:42:29 -0400

sound like you just have to move theme customizations to your project instead of hacking the official jar files...

Comment by nndiem on Lukas Lieb's answer

nndiem — Fri, 04 Oct 2019 04:39:15 -0400

Hello Lukas, We got a problem if we don't remove that library. Because in the past, we modified the old library serenity theme (by add some more css in the same css tags of serenity). Now, Serenity theme is upgraded to new version, we don't need that. If we still keep that library, our application will be broken.

Do we have more config variables so that we will specify using serenity theme default only in cockpit, don't use in our application?

thanks

Answer by Lukas Lieb

Lukas Lieb — Fri, 04 Oct 2019 04:31:42 -0400

The Cockpit will not run without the serenity libs. So simply don't delete them. There shouldn't be a problem to run your application with another theme.

Kind regards

Lukas